Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement RIP-7212/EIP-7212 #798

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: implement RIP-7212/EIP-7212 #798

merged 2 commits into from
Jun 6, 2024

Conversation

jonastheis
Copy link

1. Purpose or design rationale of this PR

This PR implements RIP-7212 (aka EIP-7212).

It follows the reference implementation of the author @ulerdogan ethereum#27540 and the more up-to-date version ulerdogan#1.

As discussed here ethereum-optimism/op-geth#168 (comment), there are additional tests added from https://github.com/google/wycheproof.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

core/vm/testdata/precompiles/p256Verify.json Outdated Show resolved Hide resolved
@jonastheis jonastheis changed the title Implement RIP-7212/EIP-7212 feat: implement RIP-7212/EIP-7212 Jun 6, 2024
@Thegaram Thegaram merged commit c2d7bd8 into develop Jun 6, 2024
8 checks passed
@Thegaram Thegaram deleted the jt/rip-7212 branch June 6, 2024 11:40
@ulerdogan
Copy link

Congrats for the very fast progress! Looking forward to see full integration with circuits and then in mainnet 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants