Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce number of heap allocations in tracing #952

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

StructLogRes and StructLog allocations amount for ~%25 of allocations that sequencer is doing. We can easily avoid them.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

HAOYUatHZ
HAOYUatHZ previously approved these changes Aug 1, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@omerfirmak omerfirmak merged commit b84f4ed into develop Aug 1, 2024
@omerfirmak omerfirmak deleted the omerfirmak/less-gc branch August 1, 2024 11:52
omerfirmak added a commit that referenced this pull request Aug 2, 2024
HAOYUatHZ pushed a commit that referenced this pull request Aug 2, 2024
omerfirmak added a commit that referenced this pull request Aug 21, 2024
omerfirmak added a commit that referenced this pull request Aug 21, 2024
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants