Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add blobHash to challenge and piHash #1264

Merged
merged 8 commits into from Apr 12, 2024

Conversation

Thegaram
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

TBA

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@roynalnaruto roynalnaruto self-requested a review April 11, 2024 21:44
@lispc
Copy link
Contributor

lispc commented Apr 12, 2024

fyi, circuit side changes #1267

@Thegaram Thegaram requested review from lispc, zimpha and colinlyguo and removed request for roynalnaruto April 12, 2024 01:51
@Thegaram Thegaram marked this pull request as ready for review April 12, 2024 01:52
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 56.12%. Comparing base (bcd9764) to head (a9062aa).

❗ Current head a9062aa differs from pull request most recent head 9b1ff7e. Consider uploading reports for the commit 9b1ff7e to get more accurate results

Files Patch % Lines
common/types/encoding/codecv1/codecv1.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1264      +/-   ##
===========================================
+ Coverage    56.11%   56.12%   +0.01%     
===========================================
  Files          156      156              
  Lines        12104    12108       +4     
===========================================
+ Hits          6792     6796       +4     
  Misses        4786     4786              
  Partials       526      526              
Flag Coverage Δ
common 61.98% <68.75%> (+0.08%) ⬆️
contracts 55.82% <ø> (ø)
coordinator 20.01% <ø> (ø)
database 42.85% <ø> (ø)
rollup 62.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thegaram Thegaram added the bump-version Bump the version tag for deployment label Apr 12, 2024
zimpha
zimpha previously approved these changes Apr 12, 2024
lispc
lispc previously approved these changes Apr 12, 2024
@github-actions github-actions bot dismissed stale reviews from zimpha and lispc via 9b1ff7e April 12, 2024 02:52
@Thegaram Thegaram merged commit 71f88b0 into develop Apr 12, 2024
@Thegaram Thegaram deleted the feat-add-blob-hash-to-challenge-and-pihash branch April 12, 2024 03:00
@roylou roylou added the bug Something isn't working label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change bug Something isn't working bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants