Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(libzkp): upgrade to v0.10.3 #1267

Merged
merged 2 commits into from
Apr 12, 2024
Merged

chore(libzkp): upgrade to v0.10.3 #1267

merged 2 commits into from
Apr 12, 2024

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Apr 12, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@lispc lispc marked this pull request as ready for review April 12, 2024 02:05
@lispc
Copy link
Contributor Author

lispc commented Apr 12, 2024

Tested. But the circuit side versioned_blob_hash is the last elem of pi hash preimage

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.86%. Comparing base (b4f8377) to head (bd13d57).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1267      +/-   ##
===========================================
- Coverage    56.14%   55.86%   -0.29%     
===========================================
  Files          156      156              
  Lines        12104    12104              
===========================================
- Hits          6796     6762      -34     
- Misses        4783     4822      +39     
+ Partials       525      520       -5     
Flag Coverage Δ
common 61.89% <ø> (ø)
coordinator 20.01% <ø> (ø)
database 42.85% <ø> (ø)
rollup 61.55% <ø> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thegaram
Thegaram previously approved these changes Apr 12, 2024
0xmountaintop
0xmountaintop previously approved these changes Apr 12, 2024
@Thegaram Thegaram added the bump-version Bump the version tag for deployment label Apr 12, 2024
@github-actions github-actions bot dismissed stale reviews from 0xmountaintop and Thegaram via a247757 April 12, 2024 02:51
@Thegaram Thegaram merged commit bcd9764 into develop Apr 12, 2024
@Thegaram Thegaram deleted the chore/libzkp-v0.10.3 branch April 12, 2024 02:51
@roylou roylou added bug Something isn't working and removed bug Something isn't working labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants