-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8 support? #54
Comments
Same here, example: ARCANEDEV/Localization#159 |
PHP 8 is generally supported. However, not via the phar file as it would break older versions unfortunately if we updated that. However, there are two options available. You can either install ocular globally or add it as a dev dependency to your project, it would look something like this:
|
Set php version to 7.4 in coverage report workflow for an issue in Scrutinizer `ocular.phar`. See scrutinizer-ci/ocular#54
Set php version to 7.4 in coverage report workflow for an issue in Scrutinizer `ocular.phar`. See scrutinizer-ci/ocular#54
Thanks for the reply, I'll change my GitHub workflow to install that globally and try that out. I'll report the results here after that. I think that there should be some guide how to use this with GitHub workflows (if there isn't one yet) - WDYT? |
@schmittjoh Installing that globally on GitHub workflow did the trick - once again big thanks for sharing that solution! |
This change to the Travis and Scrutinizer configuration makes Scrutinizer generate the coverage information itself. This change became necessary, because the PHAR version of the coverage uploader tool "ocular" provided by Scrutinizer is not compatible with PHP 8. Instead of [installing it globally][1] we drop the external coverage generation, simplifying the scrutinizer and Travis configuration at the cost of a slightly longer scrutinizer run. [1]: scrutinizer-ci/ocular#54 (comment)
This change to the Travis and Scrutinizer configuration makes Scrutinizer generate the coverage information itself. This change became necessary, because the PHAR version of the coverage uploader tool "ocular" provided by Scrutinizer is not compatible with PHP 8. Instead of [installing it globally][1] we drop the external coverage generation, simplifying the scrutinizer and Travis configuration at the cost of a slightly longer scrutinizer run. [1]: scrutinizer-ci/ocular#54 (comment)
Try to follow advice in scrutinizer-ci/ocular#54
* WIP Run phpcs, php-cs-fixer, phpstan, coverage, versions as Php8.1 They all run under Php7.4 in Github. 7.4 is EOL. We still have to run unit tests in 7.4, but I think it's time to move the tools. Note that we cannot currently run Phpstan in 8.2 because of phpstan/phpstan#8629. * Update main.yml Try running coverage as 8.0 rather than 8.1. * Update main.yml Revert Coverage to Php 7.4. * Composer Cache Directory Command set-output is deprecated. Upgrading to using Environment files as suggested by Github messages. * Coverage and Php8 Try to follow advice in scrutinizer-ci/ocular#54 * Keep Trying See https://github.com/phpowermove/docblock/pull/12/files
I'm using this in GitHub Actions like;
And I'm getting this;
And this same worked with PHP 7.4.x and now I'm getting this after I upgraded to PHP 8.0.x - any ideas how to fix this?
The text was updated successfully, but these errors were encountered: