-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run phpcs, php-cs-fixer, phpstan, coverage, versions as Php8.1 #3450
Conversation
They all run under Php7.4 in Github. 7.4 is EOL. We still have to run unit tests in 7.4, but I think it's time to move the tools. Note that we cannot currently run Phpstan in 8.2 because of phpstan/phpstan#8629.
Hmm, everything worked, except coverage, which has failed twice. Once with no error that I could see, then once, after completing the unit tests, with the following trying to upload its results:
I will try it as 8.0 (leave the others at 8.1) and see if that helps. |
Try running coverage as 8.0 rather than 8.1.
Same error for Coverage with Php 8.0. Trying 7.4. |
Revert Coverage to Php 7.4.
@MarkBaker @PowerKiKi Any idea why Coverage results upload should fail using Php 8.1/8.0 but succeed with Php 7.4? Message for 8.1/8.0 documented above. That error notwithstanding, is this change (with or without Coverage change) a bad idea? Good idea? It depends? |
Command set-output is deprecated. Upgrading to using Environment files as suggested by Github messages.
No idea why the upload should be failing, other than perhaps the underlying version of guzzle or curl.
Good idea, because we'll be dropping PHP 7.4 support in a few months time |
Try to follow advice in scrutinizer-ci/ocular#54
Thank you. It took a couple of tries to get it right, but now appears to be working. |
They all run under Php7.4 in Github. 7.4 is EOL. We still have to run unit tests in 7.4, but I think it's time to move the tools. Note that we cannot currently run Phpstan in 8.2 because of phpstan/phpstan#8629.
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.