fix(lang): UI string edits, round 2 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCatLady
force-pushed
the
fix/lang/string-edits
branch
from
179f405
to
e5ddc21
Compare
sct
reviewed
Mar 17, 2021
sct
reviewed
Mar 17, 2021
sct
reviewed
Mar 17, 2021
TheCatLady
force-pushed
the
fix/lang/string-edits
branch
from
5f63f3a
to
93c28c6
Compare
sct
reviewed
Mar 17, 2021
sct
reviewed
Mar 17, 2021
| @@ -24,29 +27,27 @@ const messages = defineMessages({ | |||
| applicationTitle: 'Application Title', | |||
| applicationurl: 'Application URL', | |||
| region: 'Discover Region', | |||
| regionTip: | |||
| 'Filter content by region (only applies to the "Popular" and "Upcoming" categories)', | |||
There was a problem hiding this comment.
I didn't remove the tip, just the parts in parentheses. We are also filtering results for genres now, and possibly more areas in the future. We can't possibly list them all, and I think we only filter where it makes sense, so I didn't feel the category clarification was necessary anymore.
I did change the region tip to say "filter content by regional availability" though, since that is a bit more clear on what the region setting actually does.
TheCatLady
force-pushed
the
fix/lang/string-edits
branch
from
73c1d61
to
c90feb8
Compare
This comment has been minimized.
This comment has been minimized.
TheCatLady
force-pushed
the
fix/lang/string-edits
branch
from
c90feb8
to
756d9a0
Compare
sct
approved these changes
Mar 18, 2021
2 tasks
|
馃帀 This PR is included in version 1.22.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More language string fixes, for things I didn't catch the last time or which were introduced since that first round of string edits. Apologies @sct and translators 馃憖
Also in this PR:
Yupvalidation on port number fields to not show errors like "port must be anumbertype, but the final value was:NaN(cast from the value...)."FormattedMessageandFormattedNumberReactMarkdownforReactMarkdownWithHtmlso that images defined using HTMLimgtags in release notes get displayed properlyScreenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A