Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): use separate json logfile for log viewer #2399

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

danshilm
Copy link
Collaborator

@danshilm danshilm commented Jan 6, 2022

Description

Parsing the log file to display the logs in the log viewer is.. huhh... hacky.
This attempts to put an end to all that and uses a separate json formatted log file that's log rotated for one day (named .machinelogs.json) that can be read from when displaying logs in the log viewer.

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

  • Fixes none

@danshilm danshilm requested a review from sct as a code owner January 6, 2022 21:28
@lgtm-com

This comment has been minimized.

@danshilm danshilm force-pushed the feat/logs/store-logs-json-format branch from b2bbea5 to 3fb8cc5 Compare January 6, 2022 21:57
server/logger.ts Show resolved Hide resolved
server/logger.ts Show resolved Hide resolved
@sct sct enabled auto-merge (squash) January 20, 2022 05:10
@sct sct merged commit ce31bef into sct:develop Jan 20, 2022
@TheCatLady TheCatLady mentioned this pull request Jan 20, 2022
1 task
@TheCatLady TheCatLady linked an issue Jan 20, 2022 that may be closed by this pull request
1 task
@shomilsaini
Copy link

There is still error in version 1.28.0. Is it fixed?

2022-01-27T20:32:18.049Z [�[31merror�[39m][Logs]: Something went wrong while fetching the logs {"errorMessage":"Unexpected end of JSON input"}

@danshilm
Copy link
Collaborator Author

@shomilsaini , can you come on our Discord and we can take a look at what the issue is?

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shomilsaini
Copy link

@shomilsaini , can you come on our Discord and we can take a look at what the issue is?

Sorry, I dont have discord.

@sct
Copy link
Owner

sct commented Apr 2, 2022

@shomilsaini , can you come on our Discord and we can take a look at what the issue is?

Sorry, I dont have discord.

Discord can run entirely in your browser. You don't need to download anything to join it.

@shomilsaini
Copy link

@shomilsaini , can you come on our Discord and we can take a look at what the issue is?

Sorry, I dont have discord.

Discord can run entirely in your browser. You don't need to download anything to join it.

I am aware of that. I just dont have a discord account. Anyhow, I checked my server today after update and the logs work now. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs give 500 error
3 participants