-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): use separate json logfile for log viewer #2399
Conversation
This comment has been minimized.
This comment has been minimized.
b2bbea5
to
3fb8cc5
Compare
There is still error in version 1.28.0. Is it fixed?
|
@shomilsaini , can you come on our Discord and we can take a look at what the issue is? |
🎉 This PR is included in version 1.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sorry, I dont have discord. |
Discord can run entirely in your browser. You don't need to download anything to join it. |
I am aware of that. I just dont have a discord account. Anyhow, I checked my server today after update and the logs work now. Thanks everyone. |
Description
Parsing the log file to display the logs in the log viewer is.. huhh... hacky.
This attempts to put an end to all that and uses a separate json formatted log file that's log rotated for one day (named
.machinelogs.json
) that can be read from when displaying logs in the log viewer.Screenshot (if UI-related)
N/A
To-Dos
yarn build
Issues Fixed or Closed