Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken scroll on recommendations page #2710

Closed
1 task done
rnsc opened this issue Apr 22, 2022 · 2 comments · Fixed by #2749
Closed
1 task done

Broken scroll on recommendations page #2710

rnsc opened this issue Apr 22, 2022 · 2 comments · Fixed by #2749

Comments

@rnsc
Copy link

rnsc commented Apr 22, 2022

Description

When you click on "Recommendations" from a movie or a tv show's page and the resulting list of recommendations is greater than 36 (always happens on my screen when there's at least 6 x 6 tiles displayed with my window size), there's a bug where the page is trying to fill with empty grey posters and the scroll bar goes crazy.

I haven't noticed the issue when there's less 36 results, although it's hard to determine the exact amount of results that triggers the issue because I have no control over the amount of results in the Recommendations page from a movie or a tv show.

I tried adjusting my window size, but that doesn't change anything.

Version

1.29.1

Steps to Reproduce

  1. Go to a movie or tv show page
  2. Scroll down and click on the "Recommendations" link to display all the recommended similar movies/tv shows
  3. Scroll down the list of recommendations to the bottom, as much as possible and the bug should trigger
    a. The bug only triggers when at least (from my testing) there are more than 36 results
    b. You should see grey posters trying to load in a loop, with the scroll bar going crazy

Screenshots

No response

Logs

No response

Platform

desktop

Device

MacBook

Operating System

macOS

Browser

Safari 15.4, Chrome Canary 102

Additional Context

No response

Code of Conduct

  • I agree to follow Overseerr's Code of Conduct
@rnsc
Copy link
Author

rnsc commented Apr 22, 2022

This is a depiction of the issue with a screenshot, the grey poster are blinking really fast when this occurs.
image

OwsleyJr added a commit that referenced this issue May 13, 2022
…tmdb api

TMDB API would only return 40 results and the recommendations page expected more. This would cause
an infinite amount of network requests. I set a limit specifically for this solving the problem.

fix #2710
danshilm pushed a commit that referenced this issue May 13, 2022
… 40 (#2749)

* fix: fixed recommendations page causing infinite network requests to tmdb api

TMDB API would only return 40 results and the recommendations page expected more. This would cause
an infinite amount of network requests. I set a limit specifically for this solving the problem.

fix #2710
OwsleyJr added a commit that referenced this issue May 19, 2022
…tmdb api

TMDB API would only return 40 results and the recommendations page expected more. This would cause
an infinite amount of network requests. I set a limit specifically for this solving the problem.

fix #2710
OwsleyJr added a commit that referenced this issue May 24, 2022
…tmdb api

TMDB API would only return 40 results and the recommendations page expected more. This would cause
an infinite amount of network requests. I set a limit specifically for this solving the problem.

fix #2710
@github-actions
Copy link

🎉 This issue has been resolved in version 1.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant