fix: better ordering of RequestButton options & properly handle failed requests #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
TheCatLady
force-pushed
the
fix/request-button
branch
from
7b6d87a
to
600e5ac
Compare
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request button ordering is now as follows:
View RequestApprove RequestorApprove X RequestsDecline RequestorDecline X RequestsView 4K RequestApprove 4K RequestorApprove X 4K RequestsDecline 4K RequestorDecline X 4K RequestsRequestRequest MoreRequest 4KRequests More in 4K(Note for reviewers: The
RequestButtoncomponent was really just reordered; there were no logic changes to the conditions for displaying each option. It looks like a lot changed, but this isn't really the case 😅)While I was working on the above, I realized that failed requests resulted in odd, undesired behavior because they currently have a
MediaStatusofUNKNOWN. It is assumed thatUNKNOWN-status media items should be requestable, but this is not the case. This PR adds a newMediaRequestStatusofFAILED(after all, a request fails and not the media item) and stops settingMediaStatusofUNKNOWNupon failure.This new
FAILEDstatus also made it super easy to add a new request list filter, so that is included here as well.To-Dos
yarn buildIssues Fixed or Closed