fix: better ordering of RequestButton options & properly handle failed requests #2944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request button ordering is now as follows:
View Request
Approve Request
orApprove X Requests
Decline Request
orDecline X Requests
View 4K Request
Approve 4K Request
orApprove X 4K Requests
Decline 4K Request
orDecline X 4K Requests
Request
Request More
Request 4K
Requests More in 4K
(Note for reviewers: The
RequestButton
component was really just reordered; there were no logic changes to the conditions for displaying each option. It looks like a lot changed, but this isn't really the case 😅)While I was working on the above, I realized that failed requests resulted in odd, undesired behavior because they currently have a
MediaStatus
ofUNKNOWN
. It is assumed thatUNKNOWN
-status media items should be requestable, but this is not the case. This PR adds a newMediaRequestStatus
ofFAILED
(after all, a request fails and not the media item) and stops settingMediaStatus
ofUNKNOWN
upon failure.This new
FAILED
status also made it super easy to add a new request list filter, so that is included here as well.To-Dos
yarn build
Issues Fixed or Closed