Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discover customization #3182

Merged
merged 16 commits into from
Jan 3, 2023
Merged

Conversation

sct
Copy link
Owner

@sct sct commented Dec 27, 2022

Description

Adds the ability to customize the sliders shown on users' discover pages. New things you can do:

  • Sort the sliders on the discover page in any order you like
  • Enable/Disable any built-in sliders you may not want to see
  • Add custom sliders with any of the following options
    • TMDB Keywords (Movie/Series)
    • TMDB Genres
    • TMDB Networks
    • TMDB Studios
    • Any TMDB search results

Was hoping to get this to everyone earlier so you could make custom holiday sliders. Next year!

Screenshot (if UI-related)

Screenshot 2022-12-27 at 11 55 34

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@cypress
Copy link

cypress bot commented Dec 27, 2022



Test summary

28 0 0 0Flakiness 0


Run details

Project overseerr
Status Passed
Commit 3b76264
Started Jan 3, 2023 6:52 AM
Ended Jan 3, 2023 6:55 AM
Duration 03:20 💡
OS Linux Ubuntu - 22.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sct sct force-pushed the feature/discover-customization branch 2 times, most recently from dcc3617 to 7274041 Compare December 28, 2022 01:34
@sct sct force-pushed the feature/discover-customization branch from 2805d7d to a3db010 Compare December 30, 2022 13:22
server/routes/settings/discover.ts Fixed Show fixed Hide fixed
Comment on lines +15 to +19
const existingSlider = await sliderRepository.findOne({
where: {
id: slider.id,
},
});

Check failure

Code scanning / CodeQL

NoSQL database query built from user-controlled sources (experimental)

(Experimental) This may be a database query that depends on [a user-provided value](1). Identified using machine learning.
@sct sct requested a review from TheCatLady December 31, 2022 01:41
@sct sct merged commit cd35748 into develop Jan 3, 2023
@sct sct deleted the feature/discover-customization branch January 3, 2023 07:04
@github-actions
Copy link

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lenaxia pushed a commit to lenaxia/overseerr-oidc that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hookable keywords sliders for Discover Tab
2 participants