fix(request): approve request when retrying request #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(request): clarify comment
sct
approved these changes
Jan 12, 2023
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
chore(request): clarify comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The retry logic was not updated when the criteria used to determine what a failed request is was updated in #2944. With the way failed requests are identified now, the only thing required when retrying a request is to accept it since TypeORM will update the parent media's status (for TV shows, when applicable) as well as send the request to the *arr when a request is accepted.
Screenshot (if UI-related)
N/A
To-Dos
yarn buildIssues Fixed or Closed