fix: prevent double encode if we are on /search endpoint #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
OwsleyJr
force-pushed
the
fix/search-encode
branch
from
252fdca
to
8662150
Compare
sct
approved these changes
Jan 13, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| pathname: router.pathname, | ||
| query: { | ||
| ...router.query, | ||
| query: encodeURIExtraParams(debouncedValue), | ||
| query: debouncedValue, |
Check failure
Code scanning / CodeQL
SQL database query built from user-controlled sources (experimental)
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EncodeURIExtraParams was encoding twice with useDiscover and useSearchInput if we were on /search. Moved the function to useDiscover as encoding on the search hook is unnecessary now.
To-Dos
yarn buildIssues Fixed or Closed