fix(request): mark request as approved if media is already available when retrying failed request #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when retrying failed request
sct
reviewed
Jan 15, 2023
sct
approved these changes
Jan 15, 2023
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
…when retrying failed request (sct#3244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failed requests whose media have become available while the request wasn't retried would fail with the error message
Media already availablewhen retried. This changes that behaviour to mark the request as approved instead.Screenshot (if UI-related)
N/A
To-Dos
yarn buildIssues Fixed or Closed