Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radarr/Sonarr "Add Server" button becomes enabled before it can be used. #328

Closed
chazlarson opened this issue Dec 15, 2020 · 0 comments
Closed

Radarr/Sonarr "Add Server" button becomes enabled before it can be used. #328

chazlarson opened this issue Dec 15, 2020 · 0 comments
Projects
Beta Release Roadmap

Comments

@chazlarson
Copy link

Describe the bug
The UI lets the user click the "Add Server" button before the dialog is filled in.

What version of Overseerr are you running?
1.5.0

To Reproduce
Steps to reproduce the behavior:

  1. Add a new Radarr/Sonarr
  2. Fill in server details, click "Test"
  3. Note that "Add Server" is now enabled
  4. Click it
  5. Be denied with two errors about empty dropdowns.

Expected behavior
The UI knows that those two values are required. It shouldn't let me try to save without them

Desktop (please complete the following information):

OS X, MS Edge
@chazlarson chazlarson added the bug label Dec 15, 2020
@sct sct added this to Backlog in Beta Release Roadmap Dec 17, 2020
@sct sct moved this from Backlog to In progress in Beta Release Roadmap Dec 17, 2020
sct added a commit that referenced this issue Dec 17, 2020
@sct
fix(frontend): clarify that radarr/sonnarr servers must be tested bef…
fc12ab8 
…ore profiles/folders appear

Also blocks "Add Server" or "Save" button until all required fields are entered

fixes #326 and #328
@sct sct moved this from In progress to Done in Beta Release Roadmap Dec 17, 2020
@sct sct closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Beta Release Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sct @chazlarson