Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid dom-nesting in TitleCard #476

Closed
ankarhem opened this issue Dec 23, 2020 · 2 comments · Fixed by #482
Closed

Invalid dom-nesting in TitleCard #476

ankarhem opened this issue Dec 23, 2020 · 2 comments · Fixed by #482
Assignees
@azoitos
Labels
released severity:low topic:ux type:bug
Projects
Beta Release Roadmap

Comments

@ankarhem
Copy link
Contributor

Describe the bug
There are descendants of an a tag which are themselves also interactive (a-tag / button).

What version of Overseerr are you running?
v1.13.0

Spec:

The a element can be wrapped around entire paragraphs, lists, tables, and so forth, even entire sections, so long as there is no interactive content within (e.g., buttons or other links).
@sct
Copy link
Owner

sct commented Dec 24, 2020

This happened when I refactored the titlecard to turn the whole thing into a link after its hovered (or clicked on mobile): e8776fd

I am aware of the dom nesting issue. Just need to refactor it a bit further and move the buttons outside of the a element and position them absolutely above the link. Will get to this eventually.

@azoitos azoitos self-assigned this Dec 24, 2020
@sct sct added this to Backlog in Beta Release Roadmap via automation Dec 24, 2020
@sct sct moved this from Backlog to In progress in Beta Release Roadmap Dec 24, 2020
azoitos added a commit that referenced this issue Dec 24, 2020
@azoitos
fix(frontend): invalid dom-nesting title card fix
a99d395 
fix #476
@azoitos azoitos mentioned this issue Dec 24, 2020
Merged
3 tasks
@sct sct closed this as completed in #482 Dec 24, 2020
Beta Release Roadmap automation moved this from In progress to Done Dec 24, 2020
sct pushed a commit that referenced this issue Dec 24, 2020
@azoitos
fix(frontend): invalid dom-nesting title card fix (#482)
f2ebba7 
fix #476
@github-actions
Copy link

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azoitos azoitos

Labels
released severity:low topic:ux type:bug
Projects
No open projects
Beta Release Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): invalid dom-nesting title card fix sct/overseerr
4 participants
@sct @samwiseg0 @ankarhem @azoitos