-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-populate server info from plex.tv API #563
Conversation
We should only present the servers the admin owns. |
4489c05
to
f14f0d2
Compare
Functional and should behave as expected, would welcome some testing prior to merge. |
c87893d
to
8a3c04b
Compare
89cb0d0
to
0889d2b
Compare
I can't even start this at the moment: Getting this error:
Alos this promise rejection in the console
|
0889d2b
to
cfd2f0f
Compare
This pull request introduces 1 alert when merging cfd2f0f into 78444a9 - view on LGTM.com new alerts:
|
113fd5d
to
52c79d2
Compare
Is the intention for it to always be set back to |
I think the "Timeout" feature needs more context. Maybe a small description that explains what the purpose of the option is. |
Maybe we should rethink the UX for this. Because of the slow load time of the dropdown, maybe we should design this in a way where it's an option to "prefill" the input fields for you. It doesn't have to constantly fetch this every time we go to the plex page (or really ever after they initially set it), right? |
1d5a681
to
62b3375
Compare
a3b6df4
to
be6e20b
Compare
Retrieve server settings from plex.tv, including checking server connectivity. Includes a refactor (non-breaking) of the plex connection code to enable settings to be passed to it without saving them (e.g. to test manual configuration without saving). fix sct#289
be6e20b
to
aa662a8
Compare
🎉 This PR is included in version 1.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Adds the ability to automatically configure plex servers from the plex.tv API.
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR