fix(ui): Uniform-size checkboxes, vertically-aligned form labels, and fixes for other UI imperfections/inconsistencies #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this look on mobile? |
|
|
|
This pull request introduces 5 alerts when merging bc2e3e2 into 82ac76b - view on LGTM.com new alerts:
|
sct
reviewed
Jan 29, 2021
TheCatLady
changed the title
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
sct
reviewed
Jan 31, 2021
|
All the inputs in the Radarr/Sonarr modals no longer fill the modal |
|
Actually, all of the labels on forms seem to have shrunk This PR Develop branch (same res) |
sct
reviewed
Feb 1, 2021
|
The request list table is cutting off content that it wouldn't before this PR Same res develop |
|
We are missing a line here
|
Makes checkbox sizes uniform, and vertical-aligns form labels better to their fields. Adjusts headings to be the same size and font weight. Also reduces the horizontal space between labels & their fields, and fixes a couple of labels which I noticed didn't have the correct htmlFor attribute.
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes checkbox sizes uniform, and vertical-aligns form labels better to their fields.
Adjusts headings to be the same size and font weight.
Also reduces the horizontal space between labels & their fields, and fixes a couple of labels which I noticed didn't have the correct htmlFor attribute.
Screenshot (if UI related)
Todos
globals.css