Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add custom title functionality #825

Merged
merged 5 commits into from
Feb 3, 2021
Merged

feat(ui): Add custom title functionality #825

merged 5 commits into from
Feb 3, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Feb 3, 2021

Description

This PR adds the option to customize the application title. In addition, it makes the title reflect the current page (currently, only the movie, series, and collection detail pages have titles w/ more than just "Overseerr").

Screenshot (if UI related)

image

Todos

  • Successful build
  • Translation keys
  • Add PageTitle shared component

Issues Fixed or Closed by this PR

@sct
Copy link
Owner

sct commented Feb 3, 2021

Instead of having to add useSettings/format the title on every page, why not a shared component that does this? Something like <PageTitle title="Search" /> which will on its own import useSettings and format the title correctly?

@TheCatLady
Copy link
Collaborator Author

Instead of having to add useSettings/format the title on every page, why not a shared component that does this? Something like <PageTitle title="Search" /> which will on its own import useSettings and format the title correctly?

Ooh, good point! I was just copying what existed already on the movie/series/collection detail pages, but it does make sense to have a shared component for this!

@TheCatLady TheCatLady marked this pull request as draft February 3, 2021 04:10
@TheCatLady TheCatLady marked this pull request as ready for review February 3, 2021 05:04
@lgtm-com
Copy link

lgtm-com bot commented Feb 3, 2021

This pull request introduces 1 alert when merging d2f393b into 2ad85d5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

src/pages/_app.tsx Outdated Show resolved Hide resolved
@sct sct merged commit 35c6bfc into sct:develop Feb 3, 2021
@TheCatLady TheCatLady deleted the custom-title branch February 3, 2021 10:57
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize the logo / Change the name of Overseerr
2 participants