fix(ui): Add additional URL & email input validation #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging c0bc669 into 026795d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 540eddd into 026795d - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging e0f2049 into 026795d - view on LGTM.com new alerts:
|
sct
reviewed
Feb 4, 2021
src/components/Settings/Notifications/NotificationsWebhook/index.tsx
Outdated
Show resolved
Hide resolved
TheCatLady
changed the title
sct
approved these changes
Feb 5, 2021
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds URL input validation from 026795d to notification settings and Radarr/Sonarr modals.
A regular expression was used for webhook URL validation, since it's possible to not have a TLD (e.g.,
http://webhook:9000/hooks/overseerr) andYup'surl()validation requires a TLD.Edit: Also add email input validation!
Todos