Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): logs viewer #997

Merged
merged 17 commits into from
Mar 17, 2021
Merged

feat(settings): logs viewer #997

merged 17 commits into from
Mar 17, 2021

Conversation

danshilm
Copy link
Collaborator

@danshilm danshilm commented Feb 22, 2021

Description

This is a follow up of #337 which adds a log viewer.

Screenshot (if UI-related)

Screenshot_182

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

  • Fixes none

server/logger.ts Outdated Show resolved Hide resolved
@sct
Copy link
Owner

sct commented Feb 23, 2021

I think we will need a button like "Pause Logs" or something to prevent them from reloading every 5 seconds. Otherwise, a plex sync could start, and you could completely lose what you were looking at.

@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2021

This pull request introduces 2 alerts when merging 3edb4b0 into d76bf32 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Missing rate limiting

@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2021

This pull request introduces 2 alerts when merging f4649b1 into d76bf32 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Missing rate limiting

@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2021

This pull request introduces 1 alert when merging 3dc628f into d76bf32 - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

this is currently a limit of 50 requests per minute
also improved formatting + cleanup
src/i18n/locale/en.json Outdated Show resolved Hide resolved
Co-authored-by: TheCatLady <52870424+TheCatLady@users.noreply.github.com>
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great. Thanks, @danshilm! One step closer to beta!

@sct sct enabled auto-merge (squash) March 17, 2021 10:26
@sct sct merged commit 54429bb into sct:develop Mar 17, 2021
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants