Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notif): add settings for Discord bot username & avatar URL #1113

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Mar 7, 2021

Description

Add a setting to allow for customization of the Discord bot username.

@sct: Should we move NotificationsDiscord.tsx, NotificationsEmail.tsx, and NotificationsTelegram.tsx into their own folders? With this change, the NotificationsDiscord and NotificationsTelegram components will both have a botUsername string. All three components also currently share several strings, including agentenabled, save, saving, and test. Is that okay?

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner March 7, 2021 22:29
@sct
Copy link
Owner

sct commented Mar 7, 2021

No need to refactor that yet.

Also, do we really need an option for the Discord username? It can be set to anything in Discord itself. 🤔

@TheCatLady
Copy link
Collaborator Author

No need to refactor that yet.

👍🏻

Also, do we really need an option for the Discord username? It can be set to anything in Discord itself. 🤔

Currently, we set the username to the application title, which overrides the setting within Discord. I think that some users may find this useful. We can also add another field to set the bot avatar.

If we don't want to add this though, then I would like to remove username from the JSON payload we send to Discord. I actually want my bot to be named something different from the application title, since it's kind of silly to have the bot username and the author in the embed be the same text IMO haha.

@sct
Copy link
Owner

sct commented Mar 7, 2021

Currently, we set the username to the application title, which overrides the setting within Discord. I think that some users may find this useful. We can also add another field to set the bot avatar.

If we don't want to add this though, then I would like to remove username from the JSON payload we send to Discord. I actually want my bot to be named something different from the application title, since it's kind of silly to have the bot username and the author in the embed be the same text IMO haha.

Oh I wasn't aware that it overwrote the setting on Discord. I guess that makes sense though. Okay yeah then I get why we need this 😄

@TheCatLady
Copy link
Collaborator Author

TheCatLady commented Mar 7, 2021

I'll also a setting to configure the bot avatar URL 😺

Edit: Done!

@TheCatLady TheCatLady force-pushed the feature/notif/discord-bot-username branch from d8f0c04 to 7a60bd2 Compare March 7, 2021 23:39
@TheCatLady TheCatLady changed the title feat(notif): add setting for Discord bot username feat(notif): add setting for Discord bot username & avatar URL Mar 7, 2021
@TheCatLady TheCatLady changed the title feat(notif): add setting for Discord bot username & avatar URL feat(notif): add settings for Discord bot username & avatar URL Mar 7, 2021
@TheCatLady TheCatLady force-pushed the feature/notif/discord-bot-username branch from 610ade1 to bcd2330 Compare March 8, 2021 00:43
@TheCatLady TheCatLady force-pushed the feature/notif/discord-bot-username branch 2 times, most recently from 2734a32 to 30856b7 Compare March 9, 2021 02:59
@sct sct enabled auto-merge (squash) March 9, 2021 05:20
@TheCatLady TheCatLady force-pushed the feature/notif/discord-bot-username branch from 30856b7 to 5c801f5 Compare March 9, 2021 12:37
@sct sct merged commit 3384eb1 into develop Mar 9, 2021
@sct sct deleted the feature/notif/discord-bot-username branch March 9, 2021 12:42
@github-actions
Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants