-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notif): add settings for Discord bot username & avatar URL #1113
Conversation
No need to refactor that yet. Also, do we really need an option for the Discord username? It can be set to anything in Discord itself. 🤔 |
👍🏻
Currently, we set the username to the application title, which overrides the setting within Discord. I think that some users may find this useful. We can also add another field to set the bot avatar. If we don't want to add this though, then I would like to remove |
Oh I wasn't aware that it overwrote the setting on Discord. I guess that makes sense though. Okay yeah then I get why we need this 😄 |
I'll also a setting to configure the bot avatar URL 😺 Edit: Done! |
d8f0c04
to
7a60bd2
Compare
610ade1
to
bcd2330
Compare
2734a32
to
30856b7
Compare
30856b7
to
5c801f5
Compare
🎉 This PR is included in version 1.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add a setting to allow for customization of the Discord bot username.
@sct: Should we move
NotificationsDiscord.tsx
,NotificationsEmail.tsx
, andNotificationsTelegram.tsx
into their own folders? With this change, theNotificationsDiscord
andNotificationsTelegram
components will both have abotUsername
string. All three components also currently share several strings, includingagentenabled
,save
,saving
, andtest
. Is that okay?Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed
N/A