-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add 'show more/less...' for studios on movie details page #1770
Conversation
We should never use |
Chevron would be better for this I feel. We should also change the color to indicate the user can interact with this and its just not another studio? |
Well, FWIW users can interact with the studios in the list as well 😛 |
True, the icon may be enough to differentiate it. |
Updated screenshot in PR body. |
@dphildebrandt You don't need to squash your commits down btw, we squash before merging anyway 😄 Makes it hard to tell what changed when you do that. |
Ah, I wasn't sure. I was trying to keep the commits atomic, and didn't think some of these changes warranted a full-blown husky-compatible commit message. |
I think that it makes it harder to difficult to review and see what changed since the last time we viewed the PR. Best to just add separate commits, especially once you've opened a PR and people have begun reviewing it. |
Show a minimum number of studios, or all if the list is short enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait! Things have been super busy!
Looks great! Thanks for the contribution again!
🎉 This PR is included in version 1.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Display a max of 3 studios before prompting to expand the list
Screenshot (if UI-related)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed