Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(email): omit action link when application URL is not configured #1806

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

When the application/action URL is not configured, we should not display the Open in ____ action link at the bottom of the email.

Also, the following refinements:

  • Resize media posters to a more reasonable size
  • Remove application title at the bottom of the email (it's unnecessary when you have the title at the top and action link text immediately above)
  • Fix application URL for password reset emails (currently, all links in the email are to the password reset page)
  • Slight refinement of language & formatting of password reset email

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner June 17, 2021 17:05
@TheCatLady TheCatLady force-pushed the fix/email/templates branch 3 times, most recently from 5dbbed0 to cb520bf Compare June 23, 2021 12:17
@sct sct enabled auto-merge (squash) July 13, 2021 09:28
@sct sct merged commit 1133a34 into develop Jul 13, 2021
@sct sct deleted the fix/email/templates branch July 13, 2021 09:32
nicospz pushed a commit to nicospz/overseerr that referenced this pull request Aug 9, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants