Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Plex library settings migration failure gracefully #2254

Merged
merged 2 commits into from Dec 4, 2021

Conversation

TheCatLady
Copy link
Collaborator

Description

Overseerr should not fail to start if the Plex library settings migration fails.

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner November 1, 2021 21:06
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should gracefully handle failed syncs in the method itself. If we fail to sync to Plex it should reset libraries to empty. Then we don't need to handle an error here at all.

@sct sct merged commit ed53810 into develop Dec 4, 2021
@sct sct deleted the fix/plex-libraries-migration branch December 4, 2021 17:42
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overseerr crashing repeatedly due to unsuccessful plex auth
2 participants