feat: countDuplicates Show how many duplicates have stacked up so far #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib/toastr/default-config.ts # src/lib/toastr/toast-noanimation.component.ts
# Conflicts: # src/lib/toastr/toast-noanimation.component.ts # src/lib/toastr/toastr.service.ts
This reverts commit a9d337b.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/lib/toastr/toast-noanimation.component.ts
|
Since this technically requires a title to be set, do we want to mention both in the example site and in the README that title is also required? Or do we somehow want to look into removing the title requirement? |
|
@yarrgh thats a good question. I think the way its implemented is ugly to the point where anyone using the feature would probably want to re-style and create their own toast. I think i'm fine putting that the toast puts it at the end of the title in the readme |
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #530 for more details