Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rugged gem: "OID too long" error #93

Merged
merged 3 commits into from
Jun 4, 2014
Merged

Rugged gem: "OID too long" error #93

merged 3 commits into from
Jun 4, 2014

Conversation

TheLonelyGhost
Copy link
Contributor

Fixes #92

@scttnlsn
Copy link
Owner

scttnlsn commented Jun 3, 2014

@TheLonelyGhost Thanks. Looks like some of the specs are failing.

@TheLonelyGhost
Copy link
Contributor Author

Sorry about that! My pre-commit hooks weren't setup like I thought.

@scttnlsn
Copy link
Owner

scttnlsn commented Jun 4, 2014

I'd rather not rescue such a generic error since it may become hard to track down other errors that could occur. How about something like:

def remote_sha
  @remote_sha ||= begin
    sha = @adapter.read(@config[:revision_file])
    sha.chomp if sha
  end
end

@TheLonelyGhost
Copy link
Contributor Author

I thought it was a narrow enough scope (read method of the adapter interface) that it wouldn't be an issue, but I suppose it would cause an error of the second kind in some cases when developing an adapter.

See the latest revision for your proposed correction.

@scttnlsn
Copy link
Owner

scttnlsn commented Jun 4, 2014

Great- thanks!

scttnlsn added a commit that referenced this pull request Jun 4, 2014
Rugged gem: "OID too long" error
@scttnlsn scttnlsn merged commit 8d51d0e into scttnlsn:master Jun 4, 2014
@TheLonelyGhost TheLonelyGhost deleted the issue-92 branch June 6, 2014 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OID too long
2 participants