Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geomnet not in CRAN #32

Open
iago-pssjd opened this issue Aug 18, 2021 · 2 comments
Open

geomnet not in CRAN #32

iago-pssjd opened this issue Aug 18, 2021 · 2 comments

Comments

@iago-pssjd
Copy link

iago-pssjd commented Aug 18, 2021

The package is archived.

When I try to build the github version I get

* creating vignettes ... ERROR
--- re-buildinggeomnet-vignette.Rmdusing rmarkdown
Quitting from lines 15-112 (geomnet-vignette.Rmd) 
Error: processing vignette 'geomnet-vignette.Rmd' failed with diagnostics:
The first two columns of `x` must be of the same type.
--- failed re-buildinggeomnet-vignette.RmdSUMMARY: processing the following file failed:geomnet-vignette.RmdError: Vignette re-building failed.
Execution halted

After installing last CRAN archived version, when trying to compile first examples in that vignette I also get

Error: The first two columns of `x` must be of the same type.

Further, I get a similar error to the one in CRAN (https://cran-archive.r-project.org/web/checks/2021/2021-06-21_check_results_geomnet.html)

Error: `loops` is `FALSE`, but `x` contains loops.
    The following values are affected:
     - `x[604, 1:2]`
     - `x[605, 1:2]`
     - `x[610, 1:2]`
     - `x[615, 1:2]`
     - `x[617, 1:2]`
     - `x[618, 1:2]`
    Execution halted 

if I do

network::as.network(bloodnet[,1:2], matrix.type = "edgelist")
Error: `loops` is `FALSE`, but `x` contains loops.
The following values are affected:
	- `x[13, 1:2]`
	- `x[14, 1:2]`
	- `x[15, 1:2]`
	- `x[16, 1:2]`
	- `x[21, 1:2]`
	- `x[22, 1:2]`

but not sure as they relates.

@iago-pssjd
Copy link
Author

iago-pssjd commented Apr 14, 2024

Dear @sctyner,

Are you interested in sending the package again to CRAN and keeping as the maintainer? In that case, I could upload a PR solving the CRAN issues in your package. Or may you think there are some reason to not publishing again (because of some serious issue or because there is a better package which exceeds this one)?

Otherwise (either you think that the package deserves to be on CRAN but you do not want to be the maintainer, or you do not answer to this message through the next days/weeks [let's say until 2024-05-10]), I will send the updated package as the new maintainer.

@iago-pssjd
Copy link
Author

Although I got solved all the CRAN issues, I found the package did not fully work with the repel = TRUE option, after trying the first example in README.Rmd. Let's hope @slowkow can enlighten (and join) us in slowkow/ggrepel#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant