Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve getting started #116

Merged
merged 8 commits into from
Dec 31, 2019
Merged

chore(docs): improve getting started #116

merged 8 commits into from
Dec 31, 2019

Conversation

stewones
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

consider this doc change as it may lead to a bad initial experience

@claassistantio
Copy link

claassistantio commented Dec 30, 2019

CLA assistant check
All committers have signed the CLA.

@stewones
Copy link
Contributor Author

uh-oh I've ended up by adding more info to get it working on a very first look

hope it helps
thanks for this amazing tool

@Villanuevand
Copy link
Contributor

@stewwan
We want to know how was your experience starting with Scully?

Base on your comments build a better documentation..

docs/getting-started.md Outdated Show resolved Hide resolved
@stewones
Copy link
Contributor Author

@stewwan
We want to know how was your experience starting with Scully?

Base on your comments build a better documentation..

so far so good but the actual getting started doesnt really help. had to spend 3 hours to get Scully running on a hello world example. that's why this PR

@stewones stewones changed the title chore(readme): change the way ng is installed chore(docs): improve getting started Dec 31, 2019
@stewones
Copy link
Contributor Author

whelp it's done.
happy new year guys!

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@Villanuevand Villanuevand merged commit 497415f into scullyio:master Dec 31, 2019
@Villanuevand
Copy link
Contributor

@stewwan Thanks for your help...
Happy New Year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants