Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scully): describe syntax highlighting #120

Merged

Conversation

d-koppenhagen
Copy link
Contributor

Closes #111

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe: Docs

What is the current behavior?

Syntax Highlighting is not described currently

Issue Number: #111

What is the new behavior?

Syntax Highlighting is described after

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@claassistantio
Copy link

claassistantio commented Dec 30, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Villanuevand is this the correct place for this? If not, can you work with @d-koppenhagen to resolve this?

Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure if "Add Syntax Highlighting" should be part of the main menu.

I think we need to add this section like "enhancement" ...

docs/blog.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-koppenhagen
We are ready to merge after add link to utils.md

@Villanuevand Villanuevand merged commit 10ec043 into scullyio:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get code highlight in markdown?
4 participants