Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scully): render doctype #132

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix(scully): render doctype #132

merged 1 commit into from
Jan 3, 2020

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Jan 3, 2020

closes #74

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

<!doctype html> is removed from generated index.html.

Issue Number: #74

What is the new behavior?

<!doctype html> remains.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@claassistantio
Copy link

claassistantio commented Jan 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias
Copy link
Contributor

@aaronfrost I would value your thoughts on this one.

@Villanuevand Villanuevand merged commit d8b2405 into scullyio:master Jan 3, 2020
@puku0x puku0x deleted the 74-fix-doctype branch January 3, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: edge case where <!doctype html> is removed from dist/static/index.html
6 participants