Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings #133

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Add warnings #133

merged 2 commits into from
Jan 3, 2020

Conversation

SanderElias
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

no warnings

What is the new behavior?

Warnings are being reased when needed

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

Other information

Villanuevand
Villanuevand approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Villanuevand Villanuevand merged commit 01c9395 into master Jan 3, 2020
@Villanuevand Villanuevand deleted the addWarnings branch January 3, 2020 12:10
@SanderElias SanderElias mentioned this pull request Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Villanuevand Villanuevand Villanuevand approved these changes

@aaronfrost aaronfrost Awaiting requested review from aaronfrost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SanderElias @Villanuevand