Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scully): update cli version #288

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

markgoho
Copy link
Contributor

@markgoho markgoho commented Feb 7, 2020

updates the instructions to reflect the release of angular v9 removing the @next tag

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Docs update

Does this PR introduce a breaking change?

  • Yes
  • No

updates the instructions to reflect the release of angular v9 removing the `@next` tag
@claassistantio
Copy link

claassistantio commented Feb 7, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @markgoho

@Villanuevand
Copy link
Contributor

@markgoho you need to sign the CLA before merge.

@markgoho
Copy link
Contributor Author

markgoho commented Feb 7, 2020

Hmm @Villanuevand I signed it just after I created the PR. Could there be a delay?

@Villanuevand Villanuevand merged commit da3c1f8 into scullyio:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants