Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins' docs in Spanish #625

Merged
merged 5 commits into from
Jun 14, 2020
Merged

Plugins' docs in Spanish #625

merged 5 commits into from
Jun 14, 2020

Conversation

GuzmanPI
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuzmanPI Great work buddy!
I found several typos in this PR.
Please could you fix all of them before to merge?

docs/plugin/contentFolderPlugin_es.md Outdated Show resolved Hide resolved
docs/plugin/contentFolderPlugin_es.md Outdated Show resolved Hide resolved
docs/plugin/contentFolderPlugin_es.md Outdated Show resolved Hide resolved
docs/plugin/contentFolderPlugin_es.md Outdated Show resolved Hide resolved
docs/plugin/jsonPlugin_es.md Outdated Show resolved Hide resolved
docs/plugins_es.md Outdated Show resolved Hide resolved
docs/plugins_es.md Outdated Show resolved Hide resolved
docs/plugins_es.md Outdated Show resolved Hide resolved
docs/plugins_es.md Outdated Show resolved Hide resolved
docs/plugins_es.md Outdated Show resolved Hide resolved
@SanderElias
Copy link
Contributor

@jorgeucano can you do one last check, and merge?

@SanderElias SanderElias changed the base branch from master to main June 12, 2020 09:04
@jorgeucano
Copy link
Contributor

@jorgeucano can you do one last check, and merge?

We need wait for the new changes... @Villanuevand show a lot of little typos in spanish

@GuzmanPI
Copy link
Contributor Author

GuzmanPI commented Jun 13, 2020

Which changes? I fixed all of theme yesterday, or am I missing any new ones?

@jorgeucano jorgeucano self-requested a review June 14, 2020 22:13
@jorgeucano jorgeucano merged commit 91cf3e8 into scullyio:main Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants