-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docsWeb): redesign docs, add nested navigation link list #753
Conversation
Total redesign of documentation styles, page structure and hierarchies. Navigation accommodates nested links and offers parameters for link positioning and styles. ISSUES CLOSED: #630
Add missed plugins FAQ entry. Remove unecessary comment in prism-js.md Correct test component paths
Looks like Jest snapshots are failing, which would make sense. |
I had a similar issue until I realized I had to pull changes from # pull any upstream changes into my local fix branch
git pull upstream fix-branch
# fix and update snapshots
npm run test
npm run jest:test -- -u
#push changes back to the fix branch on github
git push origin fix-branch
BTW - Demo of the docs looks slick. |
Remove remaining evidence of component encapsulated styles. Give `json` syntax highlighting more contrast
Language selector shows the language of the current page, links to other corresponding language pages, and indicators showing this, as well as an indicator showing if a current page has no corresponding language equivalent. Will link back to a default language page. Added additional functionality for pages to affect their parent directories' linkText and routes.
Added the ability to render different navList layouts depending on a page's Language select dropdown contains links, auto-generated from every available language. If a given page has an equivalent in another language (indicated by a The languages are filtered before constructing the navList, so the way it builds itself is unaffected by multiple languages. So there should be no blank directories in the navList for incomplete languages, for example. Also added some extra abilities to customize parent directory linkText. Also added an "introduction" page placeholder Spanish page. My Spanish is not great, so it's all Google translated, but it gives an idea of how the pages function. There is also a small js script for "clicking outside" the lang-select to close it. I preferred this over clicking the button itself to toggle it. Hopefully it's not too intrusive. I did not want to include js, but it does help the ux in this particular case imo. I chose this over a simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aaronfrost can you give this a review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks freaking awesome for me...
@donmckenna thanks for this great work....
Looks great! |
I will merge this PR the weekend, I need to change some text, but really thanks for your work and all the patience you have |
Total redesign of documentation styles, page structure and hierarchies.
Navigation accommodates nested links and offers parameters for link positioning and styles.
ISSUES CLOSED: #630
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current docs become increasingly difficult to navigate the more pages are added.
Some styles and functionality make content difficult to find and read.
Issue Number: #630
What is the new behavior?
This PR makes it easier to organize and navigate nested, related pages of documentation.
This is augmented by a style overhaul, laid out in issue #630 and https://github.com/donmckenna/scully-docs-navlist-redesign
Does this PR introduce a breaking change?
Only the docs are incompatible with previous versions of the docs.
Other information
md
plugin using Prism instead of Highlight, but this was a change in/lib/
not/scully-docs/
so I'm not sure if this is the best way to go about it..md
elements. I will be making additional documentation to describe how to use these, and possibly expand on more style guides for contributing to the docs.lang: es
pages existing in the docs. Somees
pages were versions ofen
pages which are now split into separate pages. My Spanish is not great so I unfortunately couldn't break them up myself. So because the current docs have minimal Spanish content, and to keep things simple, I've poised the navlist to accept and filteres
pages, but currently it just ignores them.en
page, and then selectses
, the page can bring them to thees
version of that same page, but if an equivalentes
page isn't available, it could just redirect to thees
version of "Getting Started" or something. I've conceptualized this and build a little place for it to go, but to keep things simple and since the current docs don't seem to use this correctly, this isn't included with this PR.