Skip to content

Commit

Permalink
SCUMM: Do not pass non-string literal but "%s" + string to displayMes…
Browse files Browse the repository at this point in the history
…sage.

Since displayMessages usualy vsnprintf internally it is not quite safe to pass
any string to it, since it might include a format argument like %n, which is
unsafe.
  • Loading branch information
Johannes Schickel committed Apr 22, 2011
1 parent e15f9cc commit 4a7360d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion engines/scumm/scumm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2494,7 +2494,7 @@ void ScummEngine_v90he::runBootscript() {

void ScummEngine::startManiac() {
debug(0, "stub startManiac()");
displayMessage(0, _("Usually, Maniac Mansion would start now. But ScummVM doesn't do that yet. To play it, go to 'Add Game' in the ScummVM start menu and select the 'Maniac' directory inside the Tentacle game directory."));
displayMessage(0, "%s", _("Usually, Maniac Mansion would start now. But ScummVM doesn't do that yet. To play it, go to 'Add Game' in the ScummVM start menu and select the 'Maniac' directory inside the Tentacle game directory."));
}

#pragma mark -
Expand Down

0 comments on commit 4a7360d

Please sign in to comment.