Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID: Update to compile with modern NDKs #1278

Merged
merged 4 commits into from May 11, 2019

Conversation

@ccawley2011
Copy link
Member

commented Aug 15, 2018

This will probably require a toolchain update on our current buildbot.

Originally from PR #1128

@sev-

This comment has been minimized.

Copy link
Member

commented Aug 18, 2018

Could you please specify which toolchain needs to be installed, so I try to take care of it?

@ccawley2011

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2018

The new buildbot worker uses SDK version r25.2.5 and NDK version r15c. Details are available here.

@ccawley2011 ccawley2011 force-pushed the ccawley2011:android branch from 4643a6f to e417a8e Sep 29, 2018

@ccawley2011 ccawley2011 force-pushed the ccawley2011:android branch from e417a8e to c19dca8 Mar 9, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Any news on this? Has the new toolchain been installed?

csnover added 2 commits Oct 25, 2017
BUILD: Remove bad & outdated flags from Android builds
Most of these flags don't work with modern Android NDKs. The ones
that may, like setting sysroot and include directories, don't work
properly with standalone toolchains. Users compiling for Android
should make sure that they properly set up include paths in their
environment CXXFLAGS/LDFLAGS as needed for the compiler to run,
instead of relying on configure to do it, since configure can't do
it in a toolchain-agnostic manner.

@ccawley2011 ccawley2011 force-pushed the ccawley2011:android branch from c19dca8 to f8f9a91 Apr 10, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

We are using Android NDK r9c on buildbot, which dates back to December 2013:

https://developer.android.com/ndk/downloads/revision_history

The latest NDK version is r19c, at the moment, dated January, 2019

@bluegr bluegr requested a review from antoniou79 Apr 29, 2019

@bluegr

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

According to our wiki, the latest Android NDK supported is r15c (July 2017):

https://wiki.scummvm.org/index.php?title=Compiling_ScummVM/Android-SDL#Install_the_Android_NDK

Perhaps @antoniou79 could have a look at this, since he has a working Android building environment?

@antoniou79

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@bluegr , I'm afraid I'm hardly up-to-date with setting up or updating a toolchain for the Android port.
What I did for the Android-SDL was much simpler; I just had to reproduce the reported issues, experiment a bit with the minimum tools that needed to be installed, implement the fix and then detail a step by step guide for others.

bgK added 2 commits May 8, 2019
ANDROID: Fix building armv5te binaries with NDK r14b
The mthumb linker flag was causing the libstdc++ library not to be found.
@bgK

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I took some time to prepare buildbot for this PR:

  • Installed NDK r14b. This version supports both Android 2.3 and ARM64 devices.
  • Dropped the MIPS build. Android devices with MIPS CPU were never widespread and are no longer supported by newer NDKs.
  • Added a ARM64 build. ARM64 is mandatory for store uploads starting August 2019.
  • Compiled liba52, FAAD, FLAC, FreeType, libjpeg-turbo, libmad, libmpeg2, libogg, libvorbis, libtheora, libpng for the armv5 and the arm64 toolchains.

Matching buildbot commit: scummvm/scummvm-sites@f707fa3

I'll do the merge in a few days if nobody objects.

@bgK bgK merged commit 7f9eaf0 into scummvm:master May 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ccawley2011 ccawley2011 deleted the ccawley2011:android branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.