-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROID: Update to compile with modern NDKs #1278
Conversation
Could you please specify which toolchain needs to be installed, so I try to take care of it? |
The new buildbot worker uses SDK version r25.2.5 and NDK version r15c. Details are available here. |
4643a6f
to
e417a8e
Compare
Any news on this? Has the new toolchain been installed? |
Most of these flags don't work with modern Android NDKs. The ones that may, like setting sysroot and include directories, don't work properly with standalone toolchains. Users compiling for Android should make sure that they properly set up include paths in their environment CXXFLAGS/LDFLAGS as needed for the compiler to run, instead of relying on configure to do it, since configure can't do it in a toolchain-agnostic manner.
We are using Android NDK r9c on buildbot, which dates back to December 2013: https://developer.android.com/ndk/downloads/revision_history The latest NDK version is r19c, at the moment, dated January, 2019 |
According to our wiki, the latest Android NDK supported is r15c (July 2017): https://wiki.scummvm.org/index.php?title=Compiling_ScummVM/Android-SDL#Install_the_Android_NDK Perhaps @antoniou79 could have a look at this, since he has a working Android building environment? |
@bluegr , I'm afraid I'm hardly up-to-date with setting up or updating a toolchain for the Android port. |
The mthumb linker flag was causing the libstdc++ library not to be found.
I took some time to prepare buildbot for this PR:
Matching buildbot commit: scummvm/scummvm-sites@f707fa3 I'll do the merge in a few days if nobody objects. |
This will probably require a toolchain update on our current buildbot.
Originally from PR #1128