SCI: Fix SQ4 Sequel police electronics store bugs #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluicebox
force-pushed
the
sq4mallpolicefixes
branch
from
260e9c7
to
5795e0b
Compare
bluegr
reviewed
Jun 17, 2019
| // the available bytes. To make room we use the clear-flag method's return | ||
| // value, which is the previous flag value, and only test if the previous room | ||
| // number is even, which only room 400 is. This patch is split into two parts | ||
| // to surround a single bnt instruction whose size changed between versions. |
There was a problem hiding this comment.
Sorry, I'm confused - can't you create a single patch in this case?
There was a problem hiding this comment.
The bnt instruction that's in the middle has a 16-bit operand in some versions and an 8-bit in the other (even though it's the same value) and there's not a mechanism for "skip 2 or 3 bytes".
I updated the comment to be clearer that it's the operand size in the instruction.
Fixes lockup, animation, and flag bugs when hiding in the electronics store, bug #10977
sluicebox
force-pushed
the
sq4mallpolicefixes
branch
from
5795e0b
to
d058889
Compare
|
Well done! Quite an edge case, and it looks like very few people actually stumbled upon these bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"How's QFG4 going?"
"Let's just say even SQ4 mall bugs are more fun..."
This fixes lockup, animation, and flag bugs when hiding in the electronics store, bug #10977.
Whew! This one has been sitting in the queue for a while, but the hole kept getting deeper. It looks like this entire sequence was never tested on CD, since it locks up immediately and has message typos and animation and flag bugs after that. I never knew you could do this stuff as it takes an inefficient escape route, which I guess is how testers missed it.
These fixes make a dozen lines of audio available for the first time, including a "new" death message in front of monolith burger.