Stream warnings #2395
Closed
Stream warnings #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(virtual base ‘Common::SeekableReadStream’ inaccessible in ‘Common::MemoryReadStreamEndian’ due to ambiguity [-Wextra])
(warning C4589 - Constructor of abstract class "Common::SeekableReadStreamEndian" ignores initializer for virtual base class "Common::ReadStreamEndian")
|
Okay, that was a quick fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMMON: fix stream class related warnings
This should take care of the warnings introduced with 1aea38c.
It is a bit of a delicate matter, since different compilers seem to have slightly different reactions.
I've locally tested MSVC 2019, gcc and clang.
So, let's see what travis says and then we can try the buildbot...