Skip to content

/ scummvm

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAKEFILE: Auto-generate dependencies for scummvm.rc #2921

Open
wants to merge 1 commit into
base: master
from
Open

MAKEFILE: Auto-generate dependencies for scummvm.rc #2921

wants to merge 1 commit into from

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Apr 6, 2021 •
edited

No description provided.

@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 6, 2021

Missing: $(srcdir)/ prefix for most deps, glue for actually using the d file, and removal of the existing deps in win32.mk.

Pro: Auto-detected
Con: Lists more than actually used. For example, if an engine is excluded, the rc file will still depend on its resources.
@orgads orgads mentioned this pull request Apr 6, 2021
Merged
@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Apr 6, 2021

I think this PR is better than #2919
@digitall
digitall reviewed Apr 6, 2021
View changes
Makefile.common Outdated Show resolved Hide resolved
@orgads orgads force-pushed the orgads:rc-deps-2 branch from e387d35 to 9eea34e Apr 6, 2021
@orgads orgads changed the title WIP: MAKEFILE: Add dependencies for scummvm.rc MAKEFILE: Auto-generate dependencies for scummvm.rc Apr 6, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 6, 2021

Ready for review.
@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 7, 2021

Don't merge yet. I forgot config.mk.
@orgads orgads force-pushed the orgads:rc-deps-2 branch from 9eea34e to 1ea793e Apr 7, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 7, 2021

Done. Ready for review.
@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 9, 2021

@digitall?
@digitall
Copy link
Member

@digitall digitall commented Apr 9, 2021

Looks reasonable. The comments you added to explain the sed magic look fine. Have not tested here as not on Windows, maybe @ccawley2011 should review?
@digitall digitall requested a review from ccawley2011 Apr 9, 2021
@ccawley2011
ccawley2011 reviewed Apr 9, 2021
View changes
Copy link
Member

@ccawley2011 ccawley2011 left a comment

Looks alright, just one minor comment.
Makefile.common Outdated Show resolved Hide resolved
@orgads
MAKEFILE: Auto-generate dependencies for scummvm.rc
Loading status checks…
1103c17
@orgads orgads force-pushed the orgads:rc-deps-2 branch from 1ea793e to 1103c17 Apr 10, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented Apr 22, 2021

ping?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitall digitall

@ccawley2011 ccawley2011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@orgads @lephilousophe @digitall @ccawley2011