TINSEL: Various Notebook changes and refactoring (that happened too close to the code freeze) #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't need vtables for the InventoryObject-objects, only for the container.
For now this should be enough to flip pages.
At the same time, name the NOTEBOOK_CLUE attribute appropriately
Changing from PascalCase to camelCase
|
Now that master is no longer frozen, this is safe to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake and pushed some TINSEL-work I had to master a bit too close to the code-freeze point. (Indeed the major renaming commits happened after the code freeze). Sorry for that mistake.
I have since reverted that commit, this PR collects up the commits so they can be applied in the future (or commented upon if someone feels like it).