Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTROPOLIS: Add better information regarding the Obsidian PC demos #4029

Merged
merged 2 commits into from Jul 5, 2022

Conversation

einstein95
Copy link
Contributor

@einstein95 einstein95 commented Jun 21, 2022

Also expand 8.3 names, make note of where found; align entries

@einstein95 einstein95 force-pushed the mtrop branch 3 times, most recently from 5c68ece to 3339bfc Compare Jun 21, 2022
0,
},

{ // Obsidian PC demo found on Multimedia Live (PC World) (v2.11, May 1997) [1996-10-03] [using 8.3 names]
Copy link
Member

@sev- sev- Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is using 8.3. games, will this entry work at all?

Copy link
Contributor Author

@einstein95 einstein95 Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically no, it'd require renaming the files. I'm trying to find a copy of the demo using the original names

Copy link
Member

@sev- sev- Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then why not add those 8.3 names to the detection?

@sev-
Copy link
Member

@sev- sev- commented Jul 2, 2022

@einstein95 please fix the detection entry, with use of 8.3 names and then it could be merged.

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Jul 4, 2022

@sev- done

@bluegr
Copy link
Member

@bluegr bluegr commented Jul 5, 2022

All the pending issues have been addressed, so this can be merged now.
Squashing, since the second commit does not conform to our formatting guidelines

@bluegr bluegr merged commit d2bb22b into scummvm:master Jul 5, 2022
1 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants