MTROPOLIS: Add better information regarding the Obsidian PC demos #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einstein95
force-pushed
the
mtrop
branch
3 times, most recently
from
5c68ece
to
3339bfc
Compare
sev-
reviewed
Jun 21, 2022
| 0, | ||
| }, | ||
|
|
||
| { // Obsidian PC demo found on Multimedia Live (PC World) (v2.11, May 1997) [1996-10-03] [using 8.3 names] |
There was a problem hiding this comment.
If it is using 8.3. games, will this entry work at all?
There was a problem hiding this comment.
Technically no, it'd require renaming the files. I'm trying to find a copy of the demo using the original names
There was a problem hiding this comment.
Then why not add those 8.3 names to the detection?
|
@einstein95 please fix the detection entry, with use of 8.3 names and then it could be merged. |
Expand 8.3 names, make note of where found; align entries
|
@sev- done |
|
All the pending issues have been addressed, so this can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expand 8.3 names, make note of where found; align entries