VIDEO: Remove logically dead code

[klusark]

It is impossible for this code to run as both newWidth and newheight will never be 0

[digitall]

@klusark : While you are correct, I think that the code is probably intended to do something different and so should be fixed, rather than removed.

I wonder if someone got their De Morgan's law confused and managed to get a && rather than an intended || in the first statement:
https://en.wikipedia.org/wiki/De_Morgan%27s_laws#Engineering

ie. line 179 should be if ((newWidth != 0) || (newHeight != 0)) {

[digitall]

Doing a git blame, this code was all added at the same time by commit 11cbdd0 (svn-id: r49079) by @clone2727 .

However, as the commit message indicates, he was just committing a patch:
"Committing the rest of the VideoDecoder Rewrite from patch #2963496."

[digitall]

Ah, this in the new patch tracker is now patch #1246:
http://sourceforge.net/p/scummvm/patches/1246/

[clone2727]

Indeed, should be "||" instead of "&&".

But don't blame DeMorgan! (Did you really have to paste a Wikipedia link?!)

[klusark]

I figured I'd just submit this instead of figuring out what it should really do as I don't have any games that use this system, so I can't test it anyway. Want me to resubmit with || instead? I just don't know what issues that could potentially cause though.

[clone2727]

Submit and I'll merge it.

Likely nothing uses this in master. I don't think Tucker uses it. It might be used in kom, but @salty-horse may have no samples either. Video resizing sucks in general, and I doubt anything we might needed for uses it.

[salty-horse]

I don't think kom "uses" it. Is it supposed to handle buggy flic files?
This is the original patch discussion: http://sourceforge.net/p/scummvm/patches/1246/

BTW, the commit message of the fix has a typo: "currenly"

[digitall]

@salty-horse : Thanks for the link, but I did link that already. My interest in this was purely that I was hoping to get the other out-of-tree fixes to the FLIC decoder in the pink engine merged at some point, so that it doesn't bitrot:
adamrimon@6d81b39

As this is a one line fix of a very obvious minor oversight, it would be nice to get this merged fairly soon... even if it gets cherry-picked and fixed.

[salty-horse]

Sorry, I skimmed the conversation and misse it. I checked, and all the FLIC files in tucker and kom have 0 for their frame width/height. This means that they never resize the video.

I don't have Passport to Peril at the moment to check if it requires that functionality.

[clone2727]

Thanks for the patch!