Update machine image for GPU CI #1084
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 84.66% 84.68% +0.01%
==========================================
Files 35 35
Lines 5112 5112
==========================================
+ Hits 4328 4329 +1
+ Misses 784 783 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Currently creating an AMI based on the instructions laid out here: Initially had tried defining a docker file, but it turns out there are complications here about talking to a GPU and it wasn't clear these would be resolved in the setup used by amazons image tutorial. It may be worth looking into the EC2 image builder for creating our images in the future: https://aws.amazon.com/image-builder/. I think it would allow automating the building of images so we can keep the base image up to date. |
.cirun.yml
Outdated
| @@ -2,7 +2,7 @@ runners: | |||
| - name: aws-gpu-runner | |||
| cloud: aws | |||
| instance_type: g4dn.xlarge | |||
| machine_image: ami-0678adbdcb4c3a662 | |||
| machine_image: ami-0139a05e194cbd9a0 | |||
There was a problem hiding this comment.
Note: This failed here: https://github.com/scverse/anndata/pull/1084/checks?check_run_id=15487580477
Is this AMI in eu-west-1 (that's default region)? If not, then you need to add region: <region-name> in here.
There was a problem hiding this comment.
I believe this didn't work because I didn't wait for the AMI to build to stop the instance, so the AMI failed to build.
There was a problem hiding this comment.
How would I tell what region it's associated with? I added eu-north-1 for the new one, but it's not super clear from the UI
There was a problem hiding this comment.
It's visible on the top right in the aws console, you already got it anyway. :)
Trying a new AMI for GPU CI