Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving source directory to src/anndata #1128

Closed
wants to merge 2 commits into from
Closed

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Sep 8, 2023

Reasoning

  • Nice consistent relative positioning in the editor side bar
  • Much harder to accidentally import from the code rather than installed version
  • Consistent with cookie cutter

Transition guide

  • All devs will need to rm -r their old anndata directory. There will be a _version.py file there + empty directories. I believe conftest.py tried to import from it.

Ping @flying-sheep

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1128 (5885d30) into main (430cf4d) will decrease coverage by 82.84%.
Report is 6 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1128       +/-   ##
==========================================
- Coverage   84.81%   1.98%   -82.84%     
==========================================
  Files          36      36               
  Lines        5335    5335               
==========================================
- Hits         4525     106     -4419     
- Misses        810    5229     +4419     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/anndata/_core/access.py 0.00% <ø> (ø)
src/anndata/_core/aligned_mapping.py 0.00% <ø> (ø)
src/anndata/_core/anndata.py 0.00% <ø> (ø)
src/anndata/_core/file_backing.py 0.00% <ø> (ø)
src/anndata/_core/index.py 0.00% <ø> (ø)
src/anndata/_core/merge.py 0.00% <ø> (ø)
src/anndata/_core/raw.py 0.00% <ø> (ø)
src/anndata/_core/sparse_dataset.py 0.00% <ø> (ø)
src/anndata/_core/views.py 0.00% <ø> (ø)
src/anndata/_io/__init__.py 0.00% <ø> (ø)
... and 25 more

... and 2 files with indirect coverage changes

@ivirshup
Copy link
Member Author

ivirshup commented Sep 8, 2023

Uhh, works on my machine?

@ivirshup
Copy link
Member Author

ivirshup commented Sep 8, 2023

If I try to run the tests in a fresh clone, but using my old install, I can reproduce. Editable install of fresh clone then running the fresh clones tests works.

Probably not following this up much more tonight.

@flying-sheep
Copy link
Member

Superseded by #1128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants