Fix error when concatenating object to categorical #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivirshup
commented
Oct 8, 2023
•
ivirshup
commented
- Closes ad.concat type unification fails for object + categorical in AnnData >= 0.10 #1170
- Tests added
- Release note added (or unnecessary)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 84.97% 82.82% -2.15%
==========================================
Files 36 36
Lines 5364 5364
==========================================
- Hits 4558 4443 -115
- Misses 806 921 +115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Oct 8, 2023
ivirshup
added a commit
that referenced
this pull request
Oct 8, 2023
…#1172) Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.