Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compat for SparseDataset usage #1185

Merged
merged 5 commits into from Oct 10, 2023
Merged

Backwards compat for SparseDataset usage #1185

merged 5 commits into from Oct 10, 2023

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Oct 10, 2023 •
edited

TODO

@ivirshup ivirshup added this to the 0.10.2 milestone Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited

Codecov Report

Merging #1185 (fb0ef1e) into main (26e9099) will decrease coverage by 2.14%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
- Coverage   85.00%   82.86%   -2.14%     
==========================================
  Files          36       36              
  Lines        5367     5376       +9     
==========================================
- Hits         4562     4455     -107     
- Misses        805      921     +116
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
anndata/_core/sparse_dataset.py 93.12% <100.00%> (+1.03%) ⬆️

... and 7 files with indirect coverage changes

@ivirshup ivirshup marked this pull request as ready for review October 10, 2023 16:05
@ivirshup ivirshup merged commit 05a3953 into scverse:main Oct 10, 2023
13 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Oct 10, 2023
@ivirshup @meeseeksmachine
Backport PR scverse#1185: Backwards compat for SparseDataset usage
150ed3f
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 10, 2023
Merged
ivirshup added a commit that referenced this pull request Oct 10, 2023
@meeseeksmachine @ivirshup
Backport PR #1185: Backwards compat for SparseDataset usage (#1190)
bdc5164 
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug 🐛 skip-gpu-ci topic: backed type: sparse 🫥
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

Keep around a deprecated SparseDataset class for this release cycle
1 participant
@ivirshup