Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aligned mapping errors #1252

Merged
merged 4 commits into from Dec 8, 2023
Merged

Improve aligned mapping errors #1252

merged 4 commits into from Dec 8, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Dec 8, 2023

@flying-sheep flying-sheep marked this pull request as ready for review December 8, 2023 08:40
@flying-sheep flying-sheep added this to the 0.10.4 milestone Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1252 (3114f6e) into main (4745b1d) will decrease coverage by 2.23%.
The diff coverage is 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   85.29%   83.07%   -2.23%     
==========================================
  Files          34       34              
  Lines        5413     5417       +4     
==========================================
- Hits         4617     4500     -117     
- Misses        796      917     +121     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
anndata/_core/aligned_mapping.py 91.18% <85.71%> (-0.30%) ⬇️

... and 8 files with indirect coverage changes

@flying-sheep flying-sheep merged commit 49ca3bd into main Dec 8, 2023
13 checks passed
@flying-sheep flying-sheep deleted the dim-errors branch December 8, 2023 10:52
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Dec 8, 2023
flying-sheep added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Contradictory information on the appropriate shape of data
2 participants