Fix outer concatenation along axis=1 for missing layers #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivirshup
commented
Jan 10, 2024
•
ivirshup
commented
- Closes Warn when anndata.concat join=outer fails because of a mismatch of layers #1286
- Tests added
- Release note added (or unnecessary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 85.14% 85.15% +0.01%
==========================================
Files 34 34
Lines 5432 5436 +4
==========================================
+ Hits 4625 4629 +4
Misses 807 807
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilan-gold
approved these changes
Jan 10, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Jan 10, 2024
ivirshup
added a commit
that referenced
this pull request
Jan 11, 2024
…ayers (#1292) Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.